Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Check module type in configure #8412

Merged
merged 2 commits into from
Oct 18, 2019
Merged

Conversation

shilman
Copy link
Member

@shilman shilman commented Oct 14, 2019

Issue: #7935

What I did

Check type of module in configure. See issue for rationale.

How to test

Delete second arg from configure in official-storybook

@shilman shilman added maintenance User-facing maintenance tasks core labels Oct 14, 2019
@vercel
Copy link

vercel bot commented Oct 14, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/storybook/monorepo/dbd63wf5n
🌍 Preview: https://monorepo-git-7935-configure-module-check.storybook.now.sh

@shilman shilman requested a review from ndelangen October 14, 2019 07:29
@shilman shilman added this to the 5.3.0 milestone Oct 18, 2019
@shilman
Copy link
Member Author

shilman commented Oct 18, 2019

Self-merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant